Bug #168

lsc fails with unrelevant message due to bad config file

Added by Frederic Soulier 6 months ago. Updated 6 months ago.

Status:Closed Start:05/02/2010
Priority:Normal Due date:
Assigned to:Jonathan Clarke % Done:

100%
Category:Core
Target version:1.2.0 Estimated time:1.00 hour
Problem in version:

Description

Using a bad taskname in the file lsc.properties for pivot attribute declaration run in issue with unrelevant error messages :

java.lang.NullPointerException: null
    at java.util.regex.Matcher.getTextLength(Matcher.java:1140) [na:1.6.0_15]
    at java.util.regex.Matcher.reset(Matcher.java:291) [na:1.6.0_15]
    at java.util.regex.Matcher.<init>(Matcher.java:211) [na:1.6.0_15]
    at java.util.regex.Pattern.matcher(Pattern.java:888) [na:1.6.0_15]
    at org.lsc.jndi.AbstractSimpleJndiService.get(AbstractSimpleJndiService.java:273) [lsc-core-1.2-SNAPSHOT.jar:na]
    at org.lsc.jndi.SimpleJndiDstService.getBean(SimpleJndiDstService.java:109) [lsc-core-1.2-SNAPSHOT.jar:na]
    at org.lsc.AbstractSynchronize.synchronize2Ldap(AbstractSynchronize.java:338) [lsc-core-1.2-SNAPSHOT.jar:na]
    at org.lsc.SimpleSynchronize.launchTask(SimpleSynchronize.java:256) [lsc-core-1.2-SNAPSHOT.jar:na]
    at org.lsc.SimpleSynchronize.launch(SimpleSynchronize.java:149) [lsc-core-1.2-SNAPSHOT.jar:na]
    at org.lsc.Launcher.run(Launcher.java:129) [lsc-core-1.2-SNAPSHOT.jar:na]
    at org.lsc.Launcher.main(Launcher.java:112) [lsc-core-1.2-SNAPSHOT.jar:na]

conf2.txt (908 Bytes) Frederic Soulier, 05/02/2010 16:43

Associated revisions

Revision 621
Added by Jonathan Clarke 6 months ago

Check properties are defined in AbstractSimpleJndiService and display a sensible error message if exceptions are encapsulated. Fixes #168

History

Updated by Frederic Soulier 6 months ago

The bad configuration file part :

lsc.tasks.**SyncUser**.dstService.filterAll = (&(sAMAccountName=*)(objectClass=user))
lsc.tasks.**FirstTask**.dstService.pivotAttrs = samaccountname

Updated by Jonathan Clarke 6 months ago

  • Status changed from New to Closed
  • Assigned to set to Jonathan Clarke
  • Target version changed from 1.2.x branch to 1.2.0
  • % Done changed from 0 to 100
  • Estimated time set to 1.00

Thanks for this, Frédéric.

AbstractSimpleJndiService never checked it's configuration properties, so ended up throwing a NullPointerException for no apparent reason.

I have fixed this so that a nicer error message is logged:

258  - ERROR - Error while launching the following task: FirstTask. Please check your configuration! (java.lang.RuntimeException: No filterId property specified in org.lsc.jndi.SimpleJndiDstService. Aborting.)

Fix will be in 1.2.0 and tonight's snapshot version.

Also available in: Atom PDF